[PATCH] D93318: [lld/mac] Set ordinal on dynamic undefined symbols in symbol table

Tue Dec 15 11:10:55 PST 2020

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm

================
Comment at: lld/MachO/SyntheticSections.cpp:757-759
+      uint16_t n_desc = nList->n_desc;
+      MachO::SET_LIBRARY_ORDINAL(n_desc, dysym->file->ordinal);
+      nList->n_desc = n_desc;
----------------
why not just pass `nList->n_desc` into `SET_LIBRARY_ORDINAL`? I suppose this is a bit more explicit about the fact that we're modifying `n_desc`, but I think it's already pretty obvious from the `SET_` in the name...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93318/new/

https://reviews.llvm.org/D93318