[PATCH] D92718: [CMake] Avoid __FakeVCSRevision.h with no git repository
Scott Linder via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 15 11:03:27 PST 2020
scott.linder added a comment.
The change makes sense to me, but at this point it might be good to add a comment for `find_first_existing_vc_file` to say what it does and what each possible return value means. Maybe something like:
# If the sources being configured are under version control, set `out_var`
# to the the path of a file which will be modified when the VCS revision
# changes, attempting to create that file if it does not exist; if no such
# file exists and one cannot be created, instead set `out_var` to the
# empty string.
#
# If the sources being configured are not under version control, do not
# define `out_var`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92718/new/
https://reviews.llvm.org/D92718
More information about the llvm-commits
mailing list