[PATCH] D92965: [NFC] Remove unused prefixes in llvm/test/CodeGen/X86

Tue Dec 15 10:36:11 PST 2020

mtrofin marked an inline comment as done.
mtrofin added inline comments.

================
Comment at: llvm/test/CodeGen/X86/extract-lowbits.ll:4
+; RUN: llc -mtriple=i686-unknown-linux-gnu -mattr=+bmi,-tbm,-bmi2 < %s | FileCheck %s --check-prefixes=X86,X86-BMI1NOTBM
+; RUN: llc -mtriple=i686-unknown-linux-gnu -mattr=+bmi,+tbm,-bmi2 < %s | FileCheck %s --check-prefix=X86
+; RUN: llc -mtriple=i686-unknown-linux-gnu -mattr=+bmi,+tbm,+bmi2 < %s | FileCheck %s --check-prefixes=X86,X86-BMI1BMI2
----------------
RKSimon wrote:
> This looks wrong - for instance - @bzhi32_a0 doesn't have any X86 checks.....
All this patch does is removes unused prefixes - so by the looks of it, @bzhi32_a0 didn't have X86 checks in the first place. Maybe because these other tests that use the X86 label produce conflicting outputs for @bzhi32_a0, case in which update_llc_test_checks does not produce an output for the function for that prefix (this is existing behavior).

We probably need more fixing to update_llc_test_checks. I think you're saying that we want to ensure each function is tested by each RUN line?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92965/new/

https://reviews.llvm.org/D92965