[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

Baptiste Saleil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 10:26:41 PST 2020


bsaleil added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:1427
+  if (Target.getTriple().isPPC64() &&
+      Target.hasFeature("paired-vector-memops")) {
+    if (Target.hasFeature("mma")) {
----------------
amyk wrote:
> Is it better to do `hasFeature()` over `PairedVectorMemops` and `HasMMA`?
`Target` is a `clang::TargetInfo` here so there is no `HasMMA` method available. I'd need to add it, so I guess it's better to use directly `hasFeature` instead of adding PPC specific code in that class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91819/new/

https://reviews.llvm.org/D91819



More information about the llvm-commits mailing list