[PATCH] D93067: [AMDGPU] Use multi-dword flat scratch for spilling

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 11:01:52 PST 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:808
+  const bool IsAGPR = hasAGPRs(RC);
+  const unsigned RegWidth = AMDGPU::getRegBitWidth(RC->getID()) / CHAR_BIT;
+
----------------
arsenm wrote:
> Why use CHAR_BIT? This now technically makes this host compiler dependent
I don't know. It is there since D49448. Fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93067/new/

https://reviews.llvm.org/D93067



More information about the llvm-commits mailing list