[PATCH] D93229: [VectorCombine] allow peeking through GEPs when creating a vector load

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 05:07:52 PST 2020


spatel added a comment.

In D93229#2453538 <https://reviews.llvm.org/D93229#2453538>, @aqjune wrote:

> Yes, we might want to know who's generating insertvalue undef and replace it with insertvalue poison.
> The shufflevector pattern works, but using poison as a placeholder will remove latent bugs.
> Maybe it is time to use poison?

If we switch to initialize with poison elements, I think we would have to swap undef with poison in regression tests and pattern matching in instsimplify/instcombine at the same time. Otherwise, we will be testing/folding the wrong patterns?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93229/new/

https://reviews.llvm.org/D93229



More information about the llvm-commits mailing list