[PATCH] D93289: [InstCombine] Remove scalable vector restriction in foldVectorBinop

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1607
   Constant *C;
-  if (match(&Inst,
+  if (isa<FixedVectorType>(Inst.getType()) &&
+      match(&Inst,
----------------
Might be worth pulling out the repeated isa/cast on Inst.getType():

auto *InstVTy = dyn_cast<FixedVectorType>(Inst.getType());


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93289/new/

https://reviews.llvm.org/D93289