[PATCH] D93258: [amdgpu] Default to code object v3

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

In D93258#2453828 <https://reviews.llvm.org/D93258#2453828>, @yaxunl wrote:

> Can they use rocm release branches of llvm/clang with the corresponding rocm release? As llvm/clang trunk is like the development branch, it is understandable that they may contain new changes that may temporarily not working with previous rocm releases.

Code object v4 does not work with any rocm release, or with code published that is not in a release. As far as open source goes, it exists only as some documentation and the change to clang that decided it was the right default to use.

That change turned out to be largely harmless as the back end uses v3 despite the docs and clang -### claiming it will use v4.

Depending on a library doesn't exist is absolutely not 'understandable'. I believe this patch undoes a mistaken step in that direction and that the hip tests are also in error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93258/new/

https://reviews.llvm.org/D93258