[PATCH] D92641: [llvm-readelf/obj] - Handle out-of-order PT_LOADs better.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 15 01:47:56 PST 2020
grimar added inline comments.
================
Comment at: llvm/unittests/Object/ELFObjectFileTest.cpp:391
+ EXPECT_EQ((const char *)Data - Buf.getBufferStart(), 0x3000);
+ EXPECT_TRUE(Data && Data[0] == 0x11);
+
----------------
jhenderson wrote:
> Perhaps you could add a single `ASSERT_TRUE(Data)` (or similar)? You could then make this and the equivalent line below something like `EXPECT_EQ(Data[0], 0x11);` which would give a nicer message.
Done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92641/new/
https://reviews.llvm.org/D92641
More information about the llvm-commits
mailing list