[PATCH] D92923: [llvm-readelf/obj][WIP] - Add support for multiple SHT_SYMTAB_SHNDX sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 01:27:09 PST 2020


jhenderson added a comment.

Sorry, this somehow slipped off my radar, and I've run out of time to do any further significant reviewing today. I've skimmed it briefly, and the general approach looks fine. I'd like ideally to find a way to avoid needing to pass both a pointer and size around for the shndx table, even if it's just to wrap it in a new class, or change to `Optional<ArrayRef<...>>` or something. If you'd like me to take a more detailed look tomorrow, I can certainly do so.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92923/new/

https://reviews.llvm.org/D92923



More information about the llvm-commits mailing list