[PATCH] D93259: [ELF] Error for out-of-range R_X86_64_[REX_]GOTPCRELX

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good to me aside from @grimar's comment.



================
Comment at: lld/test/ELF/x86-64-gotpc-err.s:8
+# CHECK:     error: {{.*}}:(.text+0x9): relocation R_X86_64_REX_GOTPCRELX out of range: 2147483648 is not in [-2147483648, 2147483647]; references data
+# CHECK-NOT: error:
+
----------------
grimar wrote:
> I'd perhaps use `--implicit-check-not=error:` instead. It feels a bit safer because doesn't depend on the order.
> Though I don't really think that the order of this error messages might change too.
I guess in theory something else could cause an error before or between the two existing errors. Do we really care though?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93259/new/

https://reviews.llvm.org/D93259