[PATCH] D93241: [AArch64InstPrinter] Change printADRPLabel to print the target address in hexadecimal form
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 15 00:52:31 PST 2020
jhenderson added a comment.
Looks like there are plenty of failing tests still?
================
Comment at: lld/test/ELF/aarch64-feature-btipac.s:174
# BTIPACDYN2-NEXT: 0x0000000070000003 (AARCH64_PAC_PLT)
\ No newline at end of file
----------------
Would you mind adding the missing new line whilst you are modifying the file, please?
================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1391
+ if (PrintBranchImmAsAddress)
+ O << formatHex((Address & -4096) + Offset);
+ else
----------------
What's this calculation about?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93241/new/
https://reviews.llvm.org/D93241
More information about the llvm-commits
mailing list