[PATCH] D93217: [llvm-readelf] - Don't print OS/Processor specific prefix for known ELF file types.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 14 23:57:38 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG83aea14ed611: [llvm-readelf] - Don't print OS/Processor specific prefix for known ELF fileā¦ (authored by grimar).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93217/new/
https://reviews.llvm.org/D93217
Files:
llvm/tools/llvm-readobj/ELFDumper.cpp
Index: llvm/tools/llvm-readobj/ELFDumper.cpp
===================================================================
--- llvm/tools/llvm-readobj/ELFDumper.cpp
+++ llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -3528,16 +3528,17 @@
"ABI Version:", std::to_string(e.e_ident[ELF::EI_ABIVERSION]));
Str = printEnum(e.e_type, makeArrayRef(ElfObjectFileType));
- if (e.e_type >= ET_LOPROC) {
- Str = "Processor Specific: (" + Str + ")";
- } else if (e.e_type >= ET_LOOS) {
- Str = "OS Specific: (" + Str + ")";
- } else if (makeArrayRef(ElfObjectFileType).end() ==
- llvm::find_if(ElfObjectFileType,
- [&](const EnumEntry<unsigned> &E) {
- return E.Value == e.e_type;
- }))
- Str = "<unknown>: " + Str;
+ if (makeArrayRef(ElfObjectFileType).end() ==
+ llvm::find_if(ElfObjectFileType, [&](const EnumEntry<unsigned> &E) {
+ return E.Value == e.e_type;
+ })) {
+ if (e.e_type >= ET_LOPROC)
+ Str = "Processor Specific: (" + Str + ")";
+ else if (e.e_type >= ET_LOOS)
+ Str = "OS Specific: (" + Str + ")";
+ else
+ Str = "<unknown>: " + Str;
+ }
printFields(OS, "Type:", Str);
Str = printEnum(e.e_machine, makeArrayRef(ElfMachineType));
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93217.311810.patch
Type: text/x-patch
Size: 1293 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201215/494b5932/attachment.bin>
More information about the llvm-commits
mailing list