[PATCH] D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/aarch64-symbols-stother.test:12
+# LLVM:      Other [ (0xC0)
+# LLVM-NEXT: ]
+
----------------
grimar wrote:
> This output looks a bit wrong.
> See the output from `mips-symbols-stother.test`:
> 
> ```
> #      MIPS-LLVM:Name: foo
> #      MIPS-LLVM:Other [
> # MIPS-LLVM-NEXT:  STO_MIPS_MICROMIPS (0x80)
> # MIPS-LLVM-NEXT:  STO_MIPS_OPTIONAL (0x4)
> # MIPS-LLVM-NEXT:  STO_MIPS_PIC (0x20)
> # MIPS-LLVM-NEXT:  STO_MIPS_PLT (0x8)
> # MIPS-LLVM-NEXT:]
> 
> #      MIPS-LLVM:Name: bar
> #      MIPS-LLVM:Other [
> # MIPS-LLVM-NEXT:  STO_MIPS_MIPS16 (0xF0)
> # MIPS-LLVM-NEXT:]
> 
> ```
> 
> I think you need to update `LLVMStyle<ELFT>::printSymbol` too.
This wasn't addressed?
You did the change in `GNUStyle<ELFT>::printSymbol`, it is responsible for `llvm-readelf` output.
If you want to change the `llvm-readobj`, then you need to update the `LLVMStyle<ELFT>::printSymbol` too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93044/new/

https://reviews.llvm.org/D93044