[PATCH] D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 23:39:58 PST 2020


grimar accepted this revision.
grimar added a comment.

LGTM with 2 minor nits. Thanks!



================
Comment at: llvm/test/tools/obj2yaml/ELF/aarch64-sym-other.yaml:10
+# CHECK:  - Name:            foo2
+# CHECK:    Other:           [ STO_AARCH64_VARIANT_PCS, 64 ]
+
----------------
nit:
in yaml2obj/obj2yaml tests we usually remove excessive indentations:


```
# CHECK: Symbols:
# CHECK:  - Name:  foo1
# CHECK:    Other: [ STO_AARCH64_VARIANT_PCS ]
# CHECK:  - Name:  foo2
# CHECK:    Other: [ STO_AARCH64_VARIANT_PCS, 64 ]
```




================
Comment at: llvm/test/tools/obj2yaml/ELF/aarch64-sym-other.yaml:22
+  - Name: foo2
+    Other: [ STO_AARCH64_VARIANT_PCS, 0x40 ]
----------------
nit: in yaml2obj/obj2yaml tests we usually align values of YAML inputs
```
  - Name:  foo1
    Other: [ STO_AARCH64_VARIANT_PCS ]
  - Name:  foo2
    Other: [ STO_AARCH64_VARIANT_PCS, 0x40 ]
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93235/new/

https://reviews.llvm.org/D93235



More information about the llvm-commits mailing list