[PATCH] D67687: [NewPM][CodeGen] Introduce machine pass and machine pass manager

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 18:20:52 PST 2020


ychen added a comment.

In D67687#2453588 <https://reviews.llvm.org/D67687#2453588>, @dblaikie wrote:

> In D67687#2452438 <https://reviews.llvm.org/D67687#2452438>, @ychen wrote:
>
>> @dblaikie The laying issue in 31ecf8d29d81d196374a562c6d2bd2c25a62861e <https://reviews.llvm.org/rG31ecf8d29d81d196374a562c6d2bd2c25a62861e> is addressed here. Do you mind taking another look? Thanks!
>
> The last delta on the patch is fairly large - not sure I can absorb it all. If the problematic dependency is no longer present, that's the key thing - I'm happy to take your word for it, if you've checked the included headers/grep'd for references of whichever libraries were incorrectly connected.

Yeah, I've checked these. Pretty sure there are no new libraries and their headers are used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67687/new/

https://reviews.llvm.org/D67687



More information about the llvm-commits mailing list