[PATCH] D93256: [GlobalISel][IRTranslator] Ensure branch probabilities are added when translating invoke edges.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 16:50:27 PST 2020


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with test nits



================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-invoke-probabilities.ll:4
+target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
+target triple = "arm64-apple-ios14"
+
----------------
Don't need these


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-invoke-probabilities.ll:15-16
+define void @pluto() local_unnamed_addr #0 align 2 personality i8* bitcast (i32 (...)* @hoge to i8*) {
+; CHECK-LABEL: @pluto
+; CHECK: successors: %bb.2(0x7ffff800), %bb.3(0x00000800)
+bb:
----------------
I would expect some instruction checks?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-invoke-probabilities.ll:35
+
+!llvm.ident = !{!0}
+
----------------
Don't need the attribute or metadata


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93256/new/

https://reviews.llvm.org/D93256



More information about the llvm-commits mailing list