[PATCH] D93255: [lld-macho] -weak_{library,framework} should always take priority

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added a reviewer: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We were not setting forceWeakImport for file paths given by
`-weak_library` if we had already loaded the file. This diff fixes that
by having `loadDylib` return a cached DylibFile instance even if we have
already loaded that file.

We still avoid emitting multiple LC_LOAD_DYLIBs, but we achieve this by
making inputFiles a SetVector instead of relying on the `loadedDylibs`
cache.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93255

Files:
  lld/MachO/Driver.cpp
  lld/MachO/DriverUtils.cpp
  lld/MachO/InputFiles.cpp
  lld/MachO/InputFiles.h
  lld/test/MachO/invalid/duplicate-symbol.s
  lld/test/MachO/weak-import.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93255.311727.patch
Type: text/x-patch
Size: 7309 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201214/8b232095/attachment.bin>