[PATCH] D93184: Make lld::wasm::link() or lld::elf::link() more thread-safe

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 15:04:56 PST 2020


MaskRay added a comment.

ELF looks good.

> Ideally I'd like to make lld entirely thread-safe and more amiable for using as a a library, that is a much larger change.

I still want to give a caution:

1. if a port calls `fatal` or `error` more than `--error-limit` times, the process will exit.
2. some ports may reset `cl::opt` and `cl::list` options so you cannot rely on these option values after calling lld.

Sometimes it is better to spawn an external lld process to do the link.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93184/new/

https://reviews.llvm.org/D93184



More information about the llvm-commits mailing list