[PATCH] D92509: ADT: Remove redundant `alignas` from IntervalMap, NFC

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 13:05:55 PST 2020


dexonsmith added a comment.

In D92509#2452929 <https://reviews.llvm.org/D92509#2452929>, @rnk wrote:

> I'm worried that this may have ended up causing issues.

Thanks for investigating; feel free to add back the `alignas` if necessary (or ask me to) if that's what's needed. Note that a straight-up revert won't work since `AlignedCharArrayUnion` was deleted; it'll have to be `std::aligned_union_t`; on that subject, if `alignas` doesn't fix it, here are the commits where I changed/deleted `AlignedCharArrayUnion`, since they could be the problem also:

- 4d8bf870a82765eb0d4fe53c82f796b957c05954 <https://reviews.llvm.org/rG4d8bf870a82765eb0d4fe53c82f796b957c05954> ADT: Remove AlignedCharArrayUnion, NFC
- d10f9863a5ac1cb681af07719650c44b48f289ce <https://reviews.llvm.org/rGd10f9863a5ac1cb681af07719650c44b48f289ce> ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC
- 4b5dc150b9862271720b3d56a3e723a55dd81838 <https://reviews.llvm.org/rG4b5dc150b9862271720b3d56a3e723a55dd81838> ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC
- 5b267fb7966157e0d79ea85cbc1d07f92f840d3c <https://reviews.llvm.org/rG5b267fb7966157e0d79ea85cbc1d07f92f840d3c> ADT: Stop peeking inside AlignedCharArrayUnion, NFC


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92509/new/

https://reviews.llvm.org/D92509



More information about the llvm-commits mailing list