[PATCH] D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize

Mon Dec 14 12:33:21 PST 2020

MaskRay added a comment.

In D92052#2452791 <https://reviews.llvm.org/D92052#2452791>, @jakubjelinek wrote:

> In D92052#2452686 <https://reviews.llvm.org/D92052#2452686>, @MaskRay wrote:
>
>> OK my bad (I don't regularly see "See Also"... ) I've sent https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97827#c9 . I'll follow up with GCC folks there. I don't subscribe gcc-patches so it will be a bit inconvenient for me if most people comment on the mailing list instead...
>
> There is nothing GNU as specific on it, all assemblers I'm aware of behave like that.
> See e.g. https://docs.huihoo.com/solaris/2.4/801-6649/801-6649.pdf
> "If section_name is a non-reserved section, attributes must be included the first time it is specified by the.section directive."
> you can search for others.  It isn't solely about what GCC emits either, there is a lot of hand-written assembler code in the wild and that also uses the documented .section directive behavior.
> I'm strongly against changing what GCC emits here.

Thanks for chiming in :) OK, I am happy to keep this logic.

@tstellar It should be a good candidate for backporting.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92052/new/

https://reviews.llvm.org/D92052