[PATCH] D92066: [LAA] Relax restrictions on early exits in loop structure

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 12:29:09 PST 2020


reames added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopLoadElimination.cpp:630
   for (Loop *L : Worklist) {
+    // Match historical behavior
+    if (!L->isRotatedForm() || !L->getExitingBlock())
----------------
Ayal wrote:
> Does this (TODO?) comment imply that in present/future this limitation can/should be dropped?
I was thinking of it more as explaining why a random check exists.  Someone interested could certainly relax this, I have no intention to pursue.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92066/new/

https://reviews.llvm.org/D92066



More information about the llvm-commits mailing list