[PATCH] D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308)

[sameeran joshi via Phabricator via llvm-commits]

sameeranjoshi added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:883
+// Loop iteration variables are not well defined for DD WHILE loop
+// in OpenMP-5.0 standard
+// Use of DO CONCURRENT inside OpenMP construct is unspecified behavior
----------------
kiranktp wrote:
> clementval wrote:
> > kiranchandramohan wrote:
> > > clementval wrote:
> > > > First line reference 4.5 and here 5.0 .... I think it would be nice to have a homogeneity here. 
> > > I think specific point might not be from the OpenMP standard. It is probably a general comment that do while loops might not have iteration variables.
> > > 
> > > But the ones below are forward looking comments.
> > Ok. Just very confusing to have 3 versions of the standard on the same comment blocks. 
> As Valentine mentioned, having different standards mentioned under one construct will be very confusing. It would be good to remove references to 5.0 and 5.1 here. As and when we start migrating the next OpenMP version, we can modify these appropriately.
> I think specific point might not be from the OpenMP standard. It is probably a general comment that do while loops might not have iteration variables.
> 
> But the ones below are forward looking comments.

Yes this is correct.
Indeed it would have been confusing when actually changing something related to code in that part, if I wouldn't have mentioned references as
Until 5.0 usage of loops apart from `do loop` is not well specified.
In 5.1 there are provisions for one of the forms of loops(`do concurrent`).
And the reference for comment related to function was already present but inorder to find `2.15.1.1` you needed to explicitly mention the `4.5` standard as there are many references to standard.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92638/new/

https://reviews.llvm.org/D92638