[PATCH] D93105: [Flang][openmp][5.0] Add task_reduction clause.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/include/flang/Parser/parse-tree.h:3427
+// (reduction-identifier:
+//                                         variable-name-list)
+struct OmpTaskReductionClause {
----------------
Is there a problem with the formatting here? 


================
Comment at: flang/include/flang/Parser/parse-tree.h:3430
+  TUPLE_CLASS_BOILERPLATE(OmpTaskReductionClause);
+  std::tuple<OmpReductionOperator, OmpObjectList> t;
+};
----------------
Is there a good reason why `OmpReductionClause` takes a list of `Designator` and here you take an `OmpObjectList`? 


================
Comment at: flang/lib/Parser/unparse.cpp:2020
+  }
+
   void Unparse(const OmpAllocateClause &x) {
----------------
Extra blank line. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93105/new/

https://reviews.llvm.org/D93105