[PATCH] D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 14 09:25:22 PST 2020
MaskRay added a comment.
In D92052#2452038 <https://reviews.llvm.org/D92052#2452038>, @jhenderson wrote:
> In D92052#2451933 <https://reviews.llvm.org/D92052#2451933>, @tstellar wrote:
>
>> @jhenderson What's your opinion on backporting this?
>
> I think it's reasonably safe, because the change just means fewer errors reported by the assembler, and it's a fix for effectively a regression, so we're just going back to older behaviour. However, I'm not the most up-to-speed with the surrounding code, so @MaskRay may be a better person to give their opinion.
@tstellar This makes an integrated assembler error less strict, so it is safe.
This is about assembling GCC's -S output with LLVM's integrated assembler, which isn't an area that I think people frequently use, so I'd also hear from @burnus why this is urgent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92052/new/
https://reviews.llvm.org/D92052
More information about the llvm-commits
mailing list