[PATCH] D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFYAML.cpp:1045
+    if (EMachine == ELF::EM_AARCH64)
+      Map["STO_AARCH64_VARIANT_PCS"] = ELF::STO_AARCH64_VARIANT_PCS;
+
----------------
grimar wrote:
> This belongs to yaml2obj functionality, not to llvm-readelf/obj and can be fixed separatelly.
> 
> I'd suggest either
> a) split this to a separate yaml2obj patch and then rebase this one on top
> b) just remove this for now and use a numeric unnamed constants (0x80) in the YAML (with a TODO/FIXME note about yaml2obj).
Right.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/aarch64-symbols-stother.test:16
+# GNU:      1: 0000000000000000 0 NOTYPE LOCAL DEFAULT [VARIANT_PCS]        UND foo1
+# GNU-NEXT: 2: 0000000000000000 0 NOTYPE LOCAL DEFAULT [VARIANT_PCS | 40] UND foo2
+
----------------
grimar wrote:
> Please align.
Sigh... sorry about that. I will fix it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93044/new/

https://reviews.llvm.org/D93044