[PATCH] D93192: [SLP] Fix vector element size for the store chains

Mon Dec 14 08:47:09 PST 2020

anton-afanasyev added a comment.

In D93192#2451838 <https://reviews.llvm.org/D93192#2451838>, @xbolva00 wrote:

> Kinda big impact on code size
>
> https://llvm-compile-time-tracker.com/compare.php?from=6c8ded0d8c3c256defaf72c0596614eea465ca27&to=fac7c7ec3ccd64d19b6d33af0a8bc2f3f7f7b047&stat=size-text
>
> Is it ok? No performance regressions?

Yes, I've observed this impact too before committing. It looks suspiciously good, but actually this fix is just exploiting potential built before. It's bug fix, so I doubt it's able to make things worse.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93192/new/

https://reviews.llvm.org/D93192