[PATCH] D93136: [test-suite] ClamAV CMake fix.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 08:02:14 PST 2020


Meinersbur requested changes to this revision.
Meinersbur added a comment.
This revision now requires changes to proceed.

Usually system introspection happens in the top-level CMakeLists.txt, but test-suite allows to selectively include subdirs, so it is a good location to do here.

If ClamAV is using gettext only, maybe use FindGettext <https://cmake.org/cmake/help/latest/module/FindGettext.html> instead?



================
Comment at: MultiSource/Applications/ClamAV/CMakeLists.txt:173
 )
+include(FindIntl)
+target_link_libraries(clamscan ${Intl_LIBRARIES})
----------------
Please use `find_package` (also see https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html#find-modules)


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93136/new/

https://reviews.llvm.org/D93136



More information about the llvm-commits mailing list