[PATCH] D92576: Remove insertDebugValuesForPHIs() from LCSSA to prevent assignments from being reordered

Mon Dec 14 06:43:15 PST 2020

n-omer added a comment.

In D92576#2451875 <https://reviews.llvm.org/D92576#2451875>, @jmorse wrote:

> LGTM, although couldn't you also just swap the basictest.ll DEBUGIFY-NEXT to be a DEBUGIFY-NOT: `call void @llvm.dbg.value` and not add the extra test.
>
> (Nabeel and I share a corporate overloard, we should leave this a little more time in case anyone else wants to chip in).

Hi Jeremy, yes I could but in the interest of preserving context information about this change I thought that having a separate test is better. If you or anyone else feels strongly enough, I'm happy to make the change.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92576/new/

https://reviews.llvm.org/D92576