[PATCH] D93149: [RISCV] Move vtype decoding and printing from RISCVInstPrinter to RISCVBaseInfo. Share with the assembly parser's debug output

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM other than nits.



================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:754
       break;
-    case KindTy::VType:
-      SmallString<32> VTypeBuf;
-      OS << "<vtype: " << getVType(VTypeBuf) << '>';
+    case KindTy::VType: {
+      OS << "<vtype: ";
----------------
nit: are these parens needed?


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1578
+    VLMUL = static_cast<RISCVVLMUL>(Flmul);
+  } else {
+    VLMUL = static_cast<RISCVVLMUL>(LmulLog2);
----------------
nit: can't remember the llvm style but should these parens be here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93149/new/

https://reviews.llvm.org/D93149