[PATCH] D93132: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3904
+
+      if (Offset->getZExtValue() % ScalarSizeInBytes ||
+          Offset->getZExtValue() / ScalarSizeInBytes > 31)
----------------
nit: Is it worth getting getting a temporary copy of the offset to avoid calling getZExtValue()? i.e.

  uint64_t OffsetVal = Offset->getZExtValue()



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93132/new/

https://reviews.llvm.org/D93132