[PATCH] D93173: [X86] Add test case for commit e52bc1d2bba794b.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/AMX/amx-intrinsic-chain.ll:4
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
The triple is different from RUN command, you can just remove it. Or remove the mtriple from command line.


================
Comment at: llvm/test/CodeGen/X86/AMX/amx-intrinsic-chain.ll:12
+; CHECK-NEXT:    movb $1, -{{[0-9]+}}(%rsp)
+; CHECK-NEXT:    movb $16, -{{[0-9]+}}(%rsp)
+; CHECK-NEXT:    movw $64, -{{[0-9]+}}(%rsp)
----------------
Does the adding chain that generates more `__tile1024i` initialization here?
But why do we need to generate more initialization for the same row and col?


================
Comment at: llvm/test/CodeGen/X86/AMX/amx-intrinsic-chain.ll:63
+attributes #8 = { nounwind }
+attributes #3 = { noinline nounwind uwtable "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="8192" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+amx-int8,+amx-tile,+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
I think you can add `avx512f` in `"target-features"` and remove `-mattr=+amx-int8 -mattr=+avx512f` in run line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93173/new/

https://reviews.llvm.org/D93173