[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

Jan Svoboda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 02:51:20 PST 2020


jansvoboda11 added a comment.

Ready for a review.



================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:287
+static void
+denormalizeString(SmallVectorImpl<const char *> &Args, const char *Spelling,
+                  CompilerInvocation::StringAllocator SA, unsigned, T &&Value) {
----------------
We should keep an eye on the number of instantiations of this function template (and `normalizeStringIntegral`).

If it grows, we can employ the SFINAE trick used for `makeFlagToValueNormalizer`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84186/new/

https://reviews.llvm.org/D84186



More information about the llvm-commits mailing list