[PATCH] D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-variant_pcs.s:1
+// RUN: llvm-mc -filetype=obj -triple aarch64-linux-gnu %s -o %t
+// RUN: llvm-readelf -symbols %t | FileCheck %s --check-prefix=GNU
----------------
I'm interested to hear what @grimar thinks, but I feel like this test would be better written with a YAML input. That will a) allow the test to be tested without AArch64 target support enabled, and b) I feel like yaml2obj gives more precise control over teh symbol details, and c) it is clearer what the inputs actually are.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4039
+  if (Symbol.st_other & ~0x3) {
+    if (this->Obj.getHeader().e_machine == ELF::EM_AARCH64) {
+      uint8_t other = Symbol.st_other & ~0x3;
----------------
Maybe we should have a test case that shows for non AARCH64 cases, this code doesn't trigger?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93044/new/

https://reviews.llvm.org/D93044