[PATCH] D93099: [PowerPC] Select the D-Form load if we know its offset meets the requirement

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:498
 
 // Some r+i load/store instructions (such as LD, STD, LDU, etc.) that require
 // restricted memrix (4-aligned) constants are alignment sensitive. If these
----------------
jsji wrote:
> Comments also needs update.
I will update it.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:504
 
 def aligned4load : PatFrag<(ops node:$ptr), (load node:$ptr), [{
+  return isOffsetMultipleOf(N, 4) || cast<LoadSDNode>(N)->getAlignment() >= 4;
----------------
jsji wrote:
> The fix has changed the semantic of this `PatFrag`, so I think we should also rename the `PatFrag` to avoid confusion.
> 
> 
The semantics now is quite the same as quadwOffsetLoad except that we are checking more on the ld/st alignment. So, how about the dwOffsetLoad/nonDwOffsetLoad ? The alignment is hidden inside the interface as it seems to be some workround to me for those TOC relocation offset.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93099/new/

https://reviews.llvm.org/D93099