[PATCH] D93067: [AMDGPU] Use multi-dword flat scratch for spilling

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 15:01:58 PST 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:923
+      Register Sub = IsSubReg
+             ? Register(getSubReg(ValueReg, getSubRegFromChannel(Lane)))
+             : ValueReg;
----------------
arsenm wrote:
> Register constructor should be unnecessary?
It gives the error otherwise: error: conditional expression is ambiguous; 'llvm::MCRegister' can be converted to 'llvm::Register' and vice versa.

Note, it is the same code as originally existed on line 848.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93067/new/

https://reviews.llvm.org/D93067



More information about the llvm-commits mailing list