[PATCH] D92842: [RFC][SelectionDAG] Add Target-Independent Compiler Barrier

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:279
 
-  if (Opcode == AArch64::CompilerBarrier) {
+  if (Opcode == AArch64::COMPILER_BARRIER) {
     O << '\t' << MAI.getCommentString() << " COMPILER BARRIER";
----------------
I don't think this should be reached any more?


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp:607
 
-  if (MI.getOpcode() == AArch64::CompilerBarrier ||
+  if (MI.getOpcode() == AArch64::COMPILER_BARRIER ||
       MI.getOpcode() == AArch64::SPACE) {
----------------
The change to `emitFunctionBody` should render this dead?


================
Comment at: llvm/test/CodeGen/X86/atomic-idempotent.ll:384
+; X86-ATOM-NEXT:    # Compiler Barrier: acquire
+; X86-ATOM-NEXT:    nop
+; X86-ATOM-NEXT:    nop
----------------
What's up with this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92842/new/

https://reviews.llvm.org/D92842