[PATCH] D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 13 23:46:31 PST 2020
grimar added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4041
+ uint8_t other = Symbol.st_other & ~0x3;
+ if (other & STO_AARCH64_VARIANT_PCS) {
+ other &= ~STO_AARCH64_VARIANT_PCS;
----------------
`other`->`Other` (llvm-readobj uses upper case naming).
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4045
+ if (other != 0)
+ Fields[5].Str.append(" | " + to_hexString(other, false));
+ Fields[5].Str.append("]");
----------------
Doesn't seem that this condition is covered by a test?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93044/new/
https://reviews.llvm.org/D93044
More information about the llvm-commits
mailing list