[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 13 09:36:08 PST 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp:97
+  assert(Type != FixedType && "FixedType should already be handled.");
+  if (30 - Bits >= 0)
+    ParameterType |= Type << (30 - Bits);
----------------
@DiggerLin  This is causing "comparison of unsigned expression >= 0 is always true" gcc warnings.

Maybe change to:
```
if (Bits < 31)
```
or change Bits to an int ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92398/new/

https://reviews.llvm.org/D92398



More information about the llvm-commits mailing list