[PATCH] D56977: [builtins] Do not set hidden attribute on Android

Ryan Prichard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 22:44:48 PST 2020


rprichard added a comment.

> Keep exporting these symbols on Android for compatibility.

For posterity, I think we want the builtins symbols not-hidden so that they can be exported from libc.so and libm.so on 32-bit targets, e.g.:

- for arm32: many `__aeabi_*` libc.so functions, `__fixunsdfdi` in libm.so, ...
- for x86: `__divdi3`, `__popcountsi2`, `__udivdi3`, `__umoddi3`

The platform continues to export these builtins for backwards compatibility with old binaries.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56977/new/

https://reviews.llvm.org/D56977



More information about the llvm-commits mailing list