[PATCH] D93139: Make debug dump more friendly to conditional debug compilation

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 22:21:19 PST 2020


mtrofin added a comment.

In D93139#2450141 <https://reviews.llvm.org/D93139#2450141>, @gjain wrote:

> @mtrofin: Thanks that works. That being said do you think that's a suitable necessity for the entire binary? Seems like all those dump functions don't really need to be included in the binary.

Not sure what the concern is - I think the facility is for debugging purposes only, i.e. not something meant to survive in the release compiler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93139/new/

https://reviews.llvm.org/D93139



More information about the llvm-commits mailing list