[PATCH] D93065: [InstCombine] Disable optimizations of select instructions that causes propagation of poison values

Congzhe Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 20:58:10 PST 2020


congzhe added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:2626
+      FalseVal->getType()->isIntegerTy() &&
+      FalseVal->getType()->getIntegerBitWidth() != 1) {
     // select C, 1, 0 -> zext C to int
----------------
aqjune wrote:
> Is this code still reachable when TrueVal/FalseVal are vectors of i1?
Thanks for the comment! Now updated to handle vectors of i1 as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93065/new/

https://reviews.llvm.org/D93065



More information about the llvm-commits mailing list