[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 11 13:00:02 PST 2020
DiggerLin marked 3 inline comments as done.
DiggerLin added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp:96
+ assert(Type != FixedType && "FixedType should already be handled.");
+ if (30 - Bits > 0)
+ ParameterType |= Type << (30 - Bits);
----------------
hubert.reinterpretcast wrote:
> This seems to be an off-by-one error? It's fine to set the rightmost two bits together.
yes, you are correct. thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92398/new/
https://reviews.llvm.org/D92398
More information about the llvm-commits
mailing list