[PATCH] D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test:355-359
 # LLVM-AARCH64-NEXT:  Tag                Type            Name/Value
 # LLVM-AARCH64-NEXT:  0x0000000070000001 AARCH64_BTI_PLT 1
 # LLVM-AARCH64-NEXT:  0x0000000070000003 AARCH64_PAC_PLT 2
+# LLVM-AARCH64-NEXT:  0x0000000070000005 AARCH64_VARIANT_PCS 3
 # LLVM-AARCH64-NEXT:  0x0000000000000000 NULL            0x0
----------------
jhenderson wrote:
> It would be nice if the whitespace were adjusted so that the name/value column all continues to line up. Same goes below.
Ack, I will fix it.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4038
+
+  if (Symbol.st_other & ~0x3) {
+    if (this->Obj.getHeader().e_machine == ELF::EM_AARCH64) {
----------------
jhenderson wrote:
> It looks like this new block of code is completely untested?
It is, but on a subsequent patch (https://reviews.llvm.org/D93045). I will add a standalone patch as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93044/new/

https://reviews.llvm.org/D93044