[PATCH] D92669: [PGO] Adjust -vp-counters-per-site.

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 10:24:25 PST 2020


On Fri, Dec 11, 2020 at 10:04 AM Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added a comment.
>
> Hm, we tell users not to use `Xclang` or `mllvm` flags because they're
> implementation details. Furthermore, we control the default value of these
> things. Could we instead change the default value to just work, instead of
> needing tweaks?
>
>
Changing the default for the static build can lead to large link time size
increase which can be harmful. If there is a way to change the default
conditionally based on build mode, that will be ideal.

David




>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D92669/new/
>
> https://reviews.llvm.org/D92669
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201211/20f8eb91/attachment.html>


More information about the llvm-commits mailing list