[PATCH] D93128: [lld][PowerPC][test] Avoid flaky failures

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 10:09:06 PST 2020


jsji added a comment.

> Can you elaborate what happens?

Because we are using the same tmp file name for this test. eg:  `common-archive-lookup.s.tmp3.a`.
Everytime we change the tests, eg: if I changed the content of tmp3.a, instead of putting 3 objects in it, 
we put 2 only.
Then we will have to remove previous `common-archive-lookup.s.tmp3.a` by forcing rebuild of buildbot.

> %t should be used for temporary files.

Yes, this is NOT changed.  If you look at the beginning of this test, we create a tmp dir, and then put all the temp source file and objects in it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93128/new/

https://reviews.llvm.org/D93128



More information about the llvm-commits mailing list