[PATCH] D92431: [SROA] Remove Dead Instructions while creating speculative instructions

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 09:40:29 PST 2020


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:4515
+    Instruction *I = dyn_cast_or_null<Instruction>(DeadInsts.pop_back_val());
+    if (I == NULL) continue;
+
----------------
This should be `if (!I) continue;`. Or `if (I == nullptr) continue;`, but that's unusual style for LLVM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92431/new/

https://reviews.llvm.org/D92431



More information about the llvm-commits mailing list