[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1941
+               0 &&
+           "VectorInfo has not be implemented.");
+    uint32_t ParaType = FI->getParameterType();
----------------
Minor nit: grammar.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1963
+    StringRef Name = MF->getName();
+    uint16_t NameLength = Name.size();
+    CommentOS << "Function name len = "
----------------
hubert.reinterpretcast wrote:
> I did not check the XL behaviour here, but it seems that the safe thing to do is to truncate the name to `INT16_MAX` characters. Also, using `int16_t` will better match the type of the field.
Please add a line before getting `NameLength` to update the length of the `StringRef` to truncate to `INT16_MAX` characters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92398/new/

https://reviews.llvm.org/D92398