[PATCH] D93096: [llvm-readelf] - Improve ELF type field dumping.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 11 09:29:48 PST 2020
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3532
+ if (e.e_type >= ET_LOPROC) {
+ Str = "Processor Specific: (" + Str + ")";
+ } else if (e.e_type >= ET_LOOS) {
----------------
I think the value is the main body and `Processor Specific` is a comment. If something needs to be placed in `()`, it should not be the value.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93096/new/
https://reviews.llvm.org/D93096
More information about the llvm-commits
mailing list