[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp:67
+
+void PPCFunctionInfo::setParameterType(ParamType Type, unsigned RegNo) {
+  unsigned CopyParamType = ParameterType;
----------------
DiggerLin wrote:
> hubert.reinterpretcast wrote:
> > hubert.reinterpretcast wrote:
> > > Is `RegNo` a correct name for this parameter? It's not used like a register number (e.g., `PPC::R3`).
> > Perhaps this function should use and also be responsible for adjusting `FixedParamNum` and `FloatingPointParamNum`. The function should be renamed to something like `appendParameterType`.
> change to ParamNo
change the interface from setParameterType(ParamType Type, unsigned RegNo)  to setParameterType(ParamType Type) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92398/new/

https://reviews.llvm.org/D92398